Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update S3 config with new legacy partition #908

Merged
merged 1 commit into from
Nov 10, 2023
Merged

update S3 config with new legacy partition #908

merged 1 commit into from
Nov 10, 2023

Conversation

bentsku
Copy link
Contributor

@bentsku bentsku commented Nov 10, 2023

Following #906, I moved the S3 configuration for the legacy provider in the dedicated section. This helps tremendously, as it would have been confusing in the regular S3 section, thanks @dominikschubert!

Preview:
https://localstack-docs-preview-pr-908.surge.sh/references/configuration/#s3
https://localstack-docs-preview-pr-908.surge.sh/references/configuration/#deprecated

Copy link

github-actions bot commented Nov 10, 2023

🎊 PR Preview has been successfully built and deployed to https://localstack-docs-preview-pr-908.surge.sh 🎊

Copy link
Member

@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bentsku bentsku merged commit 712bbfd into main Nov 10, 2023
3 checks passed
@bentsku bentsku deleted the s3-v3-config branch November 10, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants